Skip to content

Move ollama port to a constant and provide new getPort method #9623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 2 commits into from
Dec 10, 2024
Merged

Move ollama port to a constant and provide new getPort method #9623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e22a0
Adding constant and overridable method to OllamaContainer
edeandrea Dec 10, 2024
8f8665e
Update modules/ollama/src/main/java/org/testcontainers/ollama/OllamaC…
eddumelendez Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/ollama/src/main/java/org/testcontainers/ollama/OllamaContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public class OllamaContainer extends GenericContainer<OllamaContainer> {

private static final DockerImageName DOCKER_IMAGE_NAME = DockerImageName.parse("ollama/ollama");

private static final int OLLAMA_PORT = 11434;

public OllamaContainer(String image) {
this(DockerImageName.parse(image));
}
Expand All @@ -49,7 +51,7 @@ public OllamaContainer(DockerImageName dockerImageName) {
});
}
}
withExposedPorts(11434);
withExposedPorts(OLLAMA_PORT);
}

/**
Expand All @@ -74,7 +76,11 @@ public void commitToImage(String imageName) {
}
}

public int getPort() {
return getMappedPort(OLLAMA_PORT);
}

public String getEndpoint() {
return "http://" + getHost() + ":" + getMappedPort(11434);
return "http://" + getHost() + ":" + getPort();
}
}
Loading