Skip to content

Update WaitAllStrategyTest.java #9923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rian-Ismael wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −6
Open

Update WaitAllStrategyTest.java #9923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed4919c
Update WaitAllStrategyTest.java
Rian-Ismael Jan 31, 2025
09fdfd6
Merge branch 'main' into patch-1
Rian-Ismael Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions core/src/test/java/org/testcontainers/containers/wait/strategy/WaitAllStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@
import static org.mockito.Mockito.verify;

public class WaitAllStrategyTest {


private static final long CHILD_INITIAL_TIMEOUT = 10;

private static final long CHILD_DIRECT_SET_TIMEOUT = 20;

private static final long PARENT_OVERRIDE_TIMEOUT = 30;

@Mock
private GenericContainer container;

Expand All @@ -44,14 +50,14 @@ public void setUp() {
*/
@Test
public void parentTimeoutApplies() {
DummyStrategy child1 = new DummyStrategy(Duration.ofMillis(10));
child1.withStartupTimeout(Duration.ofMillis(20));
DummyStrategy child1 = new DummyStrategy(Duration.ofMillis(CHILD_INITIAL_TIMEOUT));
child1.withStartupTimeout(Duration.ofMillis(CHILD_DIRECT_SET_TIMEOUT));

assertThat(child1.startupTimeout.toMillis()).as("withStartupTimeout directly sets the timeout").isEqualTo(20L);
assertThat(child1.startupTimeout.toMillis()).as("withStartupTimeout directly sets the timeout").isEqualTo(CHILD_DIRECT_SET_TIMEOUT);

new WaitAllStrategy().withStrategy(child1).withStartupTimeout(Duration.ofMillis(30));
new WaitAllStrategy().withStrategy(child1).withStartupTimeout(Duration.ofMillis(PARENT_OVERRIDE_TIMEOUT));

assertThat(child1.startupTimeout.toMillis()).as("WaitAllStrategy overrides a child's timeout").isEqualTo(30L);
assertThat(child1.startupTimeout.toMillis()).as("WaitAllStrategy overrides a child's timeout").isEqualTo(PARENT_OVERRIDE_TIMEOUT);
}

@Test
Expand Down