Skip to content

Conversation

@seffradev
Copy link
Contributor

What does this PR do?

This renames every instance of "Testcontainers for C", "Testcontainers C", and "testcontainers-c".

Why is it important?

It makes the naming consistent throughout the project. I am expecting a minimal breakage due to renamed headers and project, but should be a quick fix.

Related issues

  • None.

This renames every instance of "Testcontainers for C", "Testcontainers C", and "testcontainers-c".
@seffradev seffradev requested a review from oleg-nenashev as a code owner July 29, 2025 17:15
@seffradev seffradev mentioned this pull request Jul 29, 2025
@oleg-nenashev
Copy link
Collaborator

@seffradev, should we rename all the instances? Or should we keep the naming for distributables, e.g.?

  • Testcontainers Native - the repo, site, project name, etc.
  • Testcontainers for C - a low-level library for C, and the respective packages
  • Testcontainers for C++ - a header lib for C++, and the respective packages
  • ... - whatever else gets added

@seffradev
Copy link
Contributor Author

It is a fair question, and I will elaborate (and possibly change this PR) when I've had time to write a thorough proposal for a design that addresses your concerns on the C API design.

In short, I'm thinking:

  • A Go-to-C bridge (called testcontainers-native-bridge or something) that is supposed to be internal.
  • A C library, consuming native-bridge (and this would be called testcontainers-c), which allows us to write an idiomatic C library that abstracts all Go code from library consumers.
  • After that, a C++ library adapter, called testcontainers-cpp.
  • And possibly other language wrappers after that.

The proposal will also mention ideas for how the modules (currently WireMock) would be set up and designed around this.

@oleg-nenashev
Copy link
Collaborator

@seffradev fine be me, and thanks. I think we are on the same page.
Definitely "Testcontainers Naative" can remain the umbrella name for the project.
No hurry to rename w.r.t the proposal

@seffradev
Copy link
Contributor Author

I'm closing this in favor of #53.

@seffradev seffradev closed this Aug 10, 2025
@oleg-nenashev
Copy link
Collaborator

OK, I think we agree in principle. I will suggest a patch with naming conventions to CONTRIBUTING, and then we can align the naming

1 similar comment
@oleg-nenashev
Copy link
Collaborator

OK, I think we agree in principle. I will suggest a patch with naming conventions to CONTRIBUTING, and then we can align the naming

@seffradev seffradev deleted the rename-to-native branch August 10, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants