Add support for container commit #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristianrgreco
added
enhancement
packages/testcontainers/src/generic-container/generic-container-commit.test.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/container-runtime/clients/container/docker-container-client.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/generic-container/generic-container-commit.test.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
@smcroskey thanks for raising the PR! This feature will be very useful. Left a few comments, LMK if you have any Qs. The lint is failing, you should be able to run |
cristianrgreco
changed the title
packages/testcontainers/src/generic-container/started-generic-container.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/generic-container/started-generic-container.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/generic-container/generic-container-commit.test.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/container-runtime/clients/image/docker-image-client.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/container-runtime/clients/container/docker-container-client.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
@smcroskey thanks for making the changes! Just a few more nitpicks |
cristianrgreco
approved these changes
Mar 14, 2025
Collaborator
|
@smcroskey thanks for the contribution! |
Contributor
Author
|
Thank you for the prompt review(s) @cristianrgreco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884
Adds support for committing a container to an image (docker container commit).
Unfortunately @types/dockerode don't expose the commit options so I've included the type in types.ts.