Add ClickHouse module #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Used this for reference for the wait strategy: https://github.com/testcontainers/testcontainers-dotnet/blob/develop/src/Testcontainers.ClickHouse/ClickHouseBuilder.cs#L91-L92 |
…ient and fix tests
Contributor
Author
|
@cristianrgreco thanks for the help! I fixed the tests and cleaned up the implementation a bit, so it should be ready for review now 😄 |
cristianrgreco
added
enhancement
cristianrgreco
changed the title
… docs inconsistencies
Contributor
Author
|
@cristianrgreco thanks for the review! I incorporated your changes, let me know if anything else needs tweaking! 😊 |
cristianrgreco
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial implementation for a ClickHouse module.
To run the tests
npx vitest run packages/modules/clickhouse/src/clickhouse-container.test.tsThe implementation and tests are heavily inspired by the Postgres module.