Skip to content

Fix resource quota being rejected when contains decimals #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristianrgreco merged 2 commits into from
Aug 1, 2025
Merged

Fix resource quota being rejected when contains decimals #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fedab36
Resource quota returns 400 when contains decimals
cristianrgreco Jul 23, 2025
22ca73a
Exclusion for rootless
cristianrgreco Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/testcontainers/src/generic-container/generic-container-resources-quota.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ describe("GenericContainer resources quota", { timeout: 180_000 }, () => {
if (!process.env["CI_ROOTLESS"]) {
it("should set resources quota", async () => {
await using container = await new GenericContainer("cristianrgreco/testcontainer:1.1.14")
.withResourcesQuota({ memory: 0.5, cpu: 1 })
.withResourcesQuota({ cpu: 1, memory: 0.5 })
.start();

const dockerContainer = await client.container.getById(container.getId());
Expand Down Expand Up @@ -44,6 +44,20 @@ describe("GenericContainer resources quota", { timeout: 180_000 }, () => {
expect(containerInfo.HostConfig.NanoCpus).toEqual(0);
});

if (!process.env["CI_ROOTLESS"]) {
it("should round values to match target int64 type", async () => {
await using container = await new GenericContainer("cristianrgreco/testcontainer:1.1.14")
.withResourcesQuota({ cpu: 0.3, memory: 0.2 })
.start();

const dockerContainer = await client.container.getById(container.getId());
const containerInfo = await dockerContainer.inspect();

expect(containerInfo.HostConfig.Memory).toEqual(214748365);
expect(containerInfo.HostConfig.NanoCpus).toEqual(300000000);
});
}

if (!process.env["CI_ROOTLESS"]) {
it("should set resources quota cpu only, memory should be 0", async () => {
await using container = await new GenericContainer("cristianrgreco/testcontainer:1.1.14")
Expand Down
4 changes: 2 additions & 2 deletions packages/testcontainers/src/generic-container/generic-container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,8 @@ export class GenericContainer implements TestContainer {
}

public withResourcesQuota({ memory, cpu }: ResourcesQuota): this {
this.hostConfig.Memory = memory !== undefined ? memory * 1024 ** 3 : undefined;
this.hostConfig.NanoCpus = cpu !== undefined ? cpu * 10 ** 9 : undefined;
this.hostConfig.Memory = memory !== undefined ? Math.ceil(memory * 1024 ** 3) : undefined;
this.hostConfig.NanoCpus = cpu !== undefined ? Math.ceil(cpu * 10 ** 9) : undefined;
return this;
}

Expand Down
Loading