Skip to content

Revert HealthCheckWaitStrategy poll #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristianrgreco merged 1 commit into from
Nov 4, 2024
Merged

Revert HealthCheckWaitStrategy poll #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 17 additions & 33 deletions packages/testcontainers/src/wait-strategies/health-check-wait-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,31 @@
import Dockerode from "dockerode";
import { AbstractWaitStrategy } from "./wait-strategy";
import { log } from "../common";
import { IntervalRetry, log } from "../common";
import { getContainerRuntimeClient } from "../container-runtime";

export class HealthCheckWaitStrategy extends AbstractWaitStrategy {
public async waitUntilReady(container: Dockerode.Container): Promise<void> {
log.debug(`Waiting for health check...`, { containerId: container.id });

const client = await getContainerRuntimeClient();
const containerEvents = await client.container.events(container, ["health_status"]);

return new Promise((resolve, reject) => {
const timeout = setTimeout(() => {
const message = `Health check not healthy after ${this.startupTimeout}ms`;
const status = await new IntervalRetry<string | undefined, Error>(100).retryUntil(
async () => (await client.container.inspect(container)).State.Health?.Status,
(healthCheckStatus) => healthCheckStatus === "healthy" || healthCheckStatus === "unhealthy",
() => {
const timeout = this.startupTimeout;
const message = `Health check not healthy after ${timeout}ms`;
log.error(message, { containerId: container.id });
containerEvents.destroy();
reject(new Error(message));
}, this.startupTimeout);

const onTerminalState = () => {
clearTimeout(timeout);
containerEvents.destroy();
log.debug(`Health check wait strategy complete`, { containerId: container.id });
};

containerEvents.on("data", (data) => {
const parsedData = JSON.parse(data);
throw new Error(message);
},
this.startupTimeout
);

const status =
parsedData.status.split(":").length === 2
? parsedData.status.split(":")[1].trim() // Docker
: parsedData.HealthStatus; // Podman
if (status !== "healthy") {
const message = `Health check failed: ${status}`;
log.error(message, { containerId: container.id });
throw new Error(message);
}

if (status === "healthy") {
resolve();
onTerminalState();
} else if (status === "unhealthy") {
const message = `Health check failed: ${status}`;
log.error(message, { containerId: container.id });
reject(new Error(message));
onTerminalState();
}
});
});
log.debug(`Health check wait strategy complete`, { containerId: container.id });
}
}
Loading