Skip to content

MySQL add isRoot parameter to executeQuery #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristianrgreco merged 2 commits into from
Jan 11, 2025
Merged

MySQL add isRoot parameter to executeQuery #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8118db
feat(mysql): add `isRoot` parameter to `executeQuery`
jeengbe Dec 11, 2024
69b6827
fix: don't test for host
jeengbe Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/modules/mysql/src/mysql-container.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,5 +99,19 @@ describe("MySqlContainer", () => {

await container.stop();
});

it("should execute a query as root user", async () => {
const container = await new MySqlContainer().withUsername("customUsername").start();

// Test non-root user
const queryResult = await container.executeQuery("SELECT CURRENT_USER() as user");
expect(queryResult).toEqual(expect.stringContaining("user\ncustomUsername"));

// Test root user
const rootQueryResult = await container.executeQuery("SELECT CURRENT_USER() as user", [], true);
expect(rootQueryResult).toEqual(expect.stringContaining("user\nroot"));

await container.stop();
});
// }
});
6 changes: 3 additions & 3 deletions packages/modules/mysql/src/mysql-container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,14 @@ export class StartedMySqlContainer extends AbstractStartedContainer {
return url.toString();
}

public async executeQuery(query: string, additionalFlags: string[] = []): Promise<string> {
public async executeQuery(query: string, additionalFlags: string[] = [], isRoot = false): Promise<string> {
const result = await this.startedTestContainer.exec([
"mysql",
"-h",
"127.0.0.1",
"-u",
this.username,
`-p${this.userPassword}`,
isRoot ? "root" : this.username,
`-p${isRoot ? this.getRootPassword() : this.getUserPassword()}`,
"-e",
`${query};`,
...additionalFlags,
Expand Down
Loading