Skip to content

Add support for Docker credential providers which do not implement list command #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristianrgreco merged 3 commits into from
Jan 25, 2025
Merged

Add support for Docker credential providers which do not implement list command #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69da6b0
fix: support `docker-credential-gcr`
glebbash Jan 23, 2025
f7e6a72
chore: fix types
glebbash Jan 23, 2025
2ed4764
fix: update type
glebbash Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/testcontainers/src/container-runtime/auth/credential-provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ describe("CredentialProvider", () => {
);
});

it("should not throw when list credentials command is not implemented", async () => {
mockExec.mockImplementationOnce((command, callback) => {
return callback(new Error(), null, "list is unimplemented\n");
});

const credentials = await credentialProvider.getAuthConfig("registry", containerRuntimeConfig);

expect(credentials).toBeUndefined();
});

it("should throw when get credentials fails", async () => {
mockExecReturns(JSON.stringify({ registry: "username" }));
mockSpawnReturns(
Expand Down
6 changes: 5 additions & 1 deletion packages/testcontainers/src/container-runtime/auth/credential-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,12 @@ export abstract class CredentialProvider implements RegistryAuthLocator {

private listCredentials(providerName: string): Promise<CredentialProviderListResponse> {
return new Promise((resolve, reject) => {
exec(`${providerName} list`, (err, stdout) => {
exec(`${providerName} list`, (err, stdout, stderr) => {
if (err) {
if (stderr === "list is unimplemented\n") {
return resolve({});
}

log.error(`An error occurred listing credentials: ${err}`);
return reject(new Error("An error occurred listing credentials"));
}
Expand Down