Skip to content

Fix flaky Selenium test #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristianrgreco merged 1 commit into from
Mar 14, 2025
Merged

Fix flaky Selenium test #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions packages/modules/selenium/src/selenium-container.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,10 @@
import path from "path";
import { Browser, Builder } from "selenium-webdriver";
import { GenericContainer, StartedTestContainer } from "testcontainers";
import { GenericContainer } from "testcontainers";
import tmp from "tmp";
import { SeleniumContainer, SELENIUM_VIDEO_IMAGE } from "./selenium-container";

describe("SeleniumContainer", { timeout: 180_000 }, () => {
let ffmpegContainer: StartedTestContainer;

beforeAll(async () => {
ffmpegContainer = await new GenericContainer(SELENIUM_VIDEO_IMAGE).withCommand(["sleep", "infinity"]).start();
});

afterAll(async () => {
await ffmpegContainer.stop();
});

const browsers = [
["CHROME", process.arch === "arm64" ? `seleniarm/standalone-chromium:112.0` : `selenium/standalone-chrome:112.0`],
["FIREFOX", process.arch === "arm64" ? `seleniarm/standalone-firefox:112.0` : `selenium/standalone-firefox:112.0`],
Expand Down Expand Up @@ -43,9 +33,13 @@ describe("SeleniumContainer", { timeout: 180_000 }, () => {
const videoFileName = path.basename(videoFilePath);
await stoppedContainer.saveRecording(videoFilePath);

const ffmpegContainer = await new GenericContainer(SELENIUM_VIDEO_IMAGE)
.withCommand(["sleep", "infinity"])
.start();
await ffmpegContainer.copyFilesToContainer([{ source: videoFilePath, target: `/tmp/${videoFileName}` }]);
const { exitCode } = await ffmpegContainer.exec(["ffprobe", `/tmp/${videoFileName}`]);
expect(exitCode).toBe(0);
await ffmpegContainer.stop();
});
});
});
1 change: 0 additions & 1 deletion packages/testcontainers/src/container-runtime/utils/image-exists.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import Dockerode from "dockerode";
import { afterEach } from "vitest";
import { ImageName } from "../image-name";

const mockImageInspect = vi.fn();
Expand Down