add support async postgres driver #320
Conversation
|
@pffijt |
| @wait_container_is_ready(*ADDITIONAL_TRANSIENT_ERRORS) | ||
| def _connect(self) -> None: | ||
| import sqlalchemy | ||
| engine = sqlalchemy.create_engine(self.get_connection_url(driver=self.DEFAULT_DRIVER)) |
There was a problem hiding this comment.
Can we just use the super call here? It looks like the method body is the same as in the parent class (except for the driver argument which is already handled in the updated get_connection_url).
There was a problem hiding this comment.
@fourteekey, could you please address this question?
|
Unresolved some of the outstanding questions, @fourteekey. We'll also have to regenerate the lock files in |
|
All questions have been resolved. |
|
closing in favor of #445 because i believe it will handle this use case, let me know if this is not the case |
…445) Updates the pg testcontainer implementation to not use (and not install) SQLAlchemy nor psycopg2. Closes: #340 Closes: #336 Closes: #320 --------- Co-authored-by: Jason Turim <[email protected]>
…445) Updates the pg testcontainer implementation to not use (and not install) SQLAlchemy nor psycopg2. Closes: #340 Closes: #336 Closes: #320 --------- Co-authored-by: Jason Turim <[email protected]>
…estcontainers#445) Updates the pg testcontainer implementation to not use (and not install) SQLAlchemy nor psycopg2. Closes: testcontainers#340 Closes: testcontainers#336 Closes: testcontainers#320 --------- Co-authored-by: Jason Turim <[email protected]>
No description provided.