feat: add spanner rest port and upgrade google-cloud-sdk version#117
Open
plaflamme wants to merge 14 commits intotestcontainers:mainfrom
Open
feat: add spanner rest port and upgrade google-cloud-sdk version#117plaflamme wants to merge 14 commits intotestcontainers:mainfrom
plaflamme wants to merge 14 commits intotestcontainers:mainfrom
Conversation
DDtKey
reviewed
Apr 9, 2024
Contributor
DDtKey
left a comment
DDtKey
left a comment
There was a problem hiding this comment.
Thank you for the contribution! 🙏
I've left couple of comments, please take a look
DDtKey
changed the title
Turns out that these were `pub`, but impossible to use since `CloudSdk::new` was not also `pub`. So removing `pub` should have no consequence.
Author
|
@DDtKey 👋 it's been a while... reviving this one. With the latest changes on PTAL |
Co-authored-by: Frank Elsinga <frank@elsinga.de>
DDtKey
approved these changes
Aug 1, 2025
DDtKey
changed the title
Author
|
@DDtKey not sure there's anything to do about the check failures? They seem unrelated to these changes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does 2 things: