chore(deps): expose compile feature to pass through testcontainers/ring or aws-lc-rs#442
Open
gillyobeast wants to merge 1 commit intotestcontainers:mainfrom
Open
chore(deps): expose compile feature to pass through testcontainers/ring or aws-lc-rs#442gillyobeast wants to merge 1 commit intotestcontainers:mainfrom
gillyobeast wants to merge 1 commit intotestcontainers:mainfrom
Conversation
Author
|
@DDtKey hi sorry for the direct ping, could i get a review on this please? it's the last thing blocking me from removing |
Author
|
@DDtKey bump :D |
Author
|
sorry for chasing so much but this is now blocking vulnerability updates, specifically we need to be able to get away from ring to switch from jsonwebtoken 9.x to 10.x, which we need to do because 9.x has a vulnerability: GHSA-h395-gr6q-cpjc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm working through switching from
ringtoaws-lc-rsfor our crypto provider, and this crate is pullingringin as it depends ontestcontainerswith the default feature set.This PR adds similar flags to
testcontainersto select between the two crypto crates, or none: https://github.com/testcontainers/testcontainers-rs/blob/809aa234a1b52e2bff4ad6493f26f4aae4938d29/testcontainers/Cargo.toml#L54-L58