feat: add image hook to run commands before ready#766
Merged
DDtKey merged 1 commit intotestcontainers:mainfrom Feb 6, 2025
yuri-becker:main
Merged
feat: add image hook to run commands before ready#766DDtKey merged 1 commit intotestcontainers:mainfrom yuri-becker:main
DDtKey merged 1 commit intotestcontainers:mainfrom
yuri-becker:main
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DDtKey
approved these changes
Feb 5, 2025
DDtKey
changed the title
auto-merge was automatically disabled
February 6, 2025 11:04
Head branch was pushed to by a user without write access
Merged
Contributor
Author
|
Thanks for merging :) |
DDtKey
pushed a commit
that referenced
this pull request
Feb 7, 2025
## 🤖 New release * `testcontainers`: 0.23.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.23.2] - 2025-02-06 ### Details #### Documentation - Add examples of `ImageExt` usage and cover `GenericImage` (#747) #### Features - Add `cap_add` and `cap_drop` support (#726) - Add support for user-configured labels (#756) - Reusable containers (#757) - Add image hook to run commands before ready (#766) #### Miscellaneous Tasks - Update thiserror requirement from 1.0.60 to 2.0.3 (#754) - Bump the bollard dep to latest (#759) #### Testing - Deflake the test `start_containers_in_parallel` (#748) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
DDtKey
added a commit
to testcontainers/testcontainers-rs-modules-community
that referenced
this pull request
Feb 10, 2025
Module for [Dex](https://dexidp.io/). A community module for Java exists as well: https://github.com/Kehrlann/testcontainers-dex/tree/main Dependent on this PR in the core crate: testcontainers/testcontainers-rs#766 --------- Co-authored-by: Artem Medvedev <i@ddtkey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, i was implementing a module for Dex and needed something like containerIsStarting in the Java implementation.
I wrote a test and confirmed it works with my module implementation – see testcontainers/testcontainers-rs-modules-community#286 for that PR.
Please let me know what i can improve to get this merged. I hope it is okay to implement this without an issue :)