build: propagate ring/aws-lc-rs feature flags to bollard#781
Merged
DDtKey merged 3 commits intotestcontainers:mainfrom Mar 24, 2025
Merged
build: propagate ring/aws-lc-rs feature flags to bollard#781DDtKey merged 3 commits intotestcontainers:mainfrom
DDtKey merged 3 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DDtKey
reviewed
Mar 24, 2025
Contributor
|
Also test suite relies on cargo hack. We need to adjust CI to have ssl feature enabled |
Contributor
|
Thank you for the contribution 👍 |
DDtKey
approved these changes
Mar 24, 2025
Contributor
|
LGTM 🚀 Later we will need to think about optimization of CI, because matrix is increased significantly (9 -> 31 use-case, ~6m -> 17m). Not a blocker for this though Thank you one more time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for consumers to be able to switch between
ringandaws-lc-rscleanly withouttestcontainers_rsbringing in the wrong library, add feature flags that are propagated through tobollardto switch between the two ssl providers.