refactor: testimages and tests to use builder API#804
Merged
DDtKey merged 9 commits intotestcontainers:mainfrom Jul 22, 2025
Merged
refactor: testimages and tests to use builder API#804DDtKey merged 9 commits intotestcontainers:mainfrom
DDtKey merged 9 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mbodmer
changed the title
Contributor
|
We can make a chain of PRs, this can point to branch of #801. So it will show clear diff |
Contributor
Author
Contributor
|
Right, that's your fork's branch |
Contributor
Author
|
Could you please start the build again? Thanks |
mbodmer
force-pushed
the
feat/refactor-testimages
branch
from
0997068 to
7c1df2e
Compare
Contributor
Author
|
rebased to the current state of #801 |
mbodmer
force-pushed
the
feat/refactor-testimages
branch
from
7c1df2e to
a6e8e01
Compare
Contributor
Author
|
Again, rebased to the current state of #801 |
Contributor
|
@mbodmer the builder api pr has been merged, let's tackle this one next :) |
Signed-off-by: mbodmer <marc.bodmer@email.ch>
Signed-off-by: mbodmer <marc.bodmer@email.ch>
Signed-off-by: mbodmer <marc.bodmer@email.ch>
Signed-off-by: mbodmer <marc.bodmer@email.ch>
Signed-off-by: mbodmer <marc.bodmer@email.ch>
Signed-off-by: mbodmer <marc.bodmer@email.ch>
Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
Signed-off-by: mbodmer <marc.bodmer@email.ch>
mbodmer
force-pushed
the
feat/refactor-testimages
branch
from
42e8468 to
210dd56
Compare
Contributor
Author
|
A good feature for future improvement would be having an ignore list or better recognize .dockerignore/.containerignore files, when adding a directory to the build context. |
DDtKey
approved these changes
Jul 19, 2025
mervyn-mccreight
approved these changes
Jul 22, 2025
…ner.rs unittests Signed-off-by: mbodmer <marc.bodmer@email.ch>
Merged
mervyn-mccreight
pushed a commit
that referenced
this pull request
Jul 27, 2025
## 🤖 New release
* `testcontainers`: 0.24.0 -> 0.25.0 (⚠ API breaking changes)
### ⚠ `testcontainers` breaking changes
```text
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/enum_variant_added.ron
Failed in:
variant ClientError:BuildImage in /tmp/.tmp8ymZuo/testcontainers-rs/testcontainers/src/core/client.rs:71
variant ClientError:BuildImage in /tmp/.tmp8ymZuo/testcontainers-rs/testcontainers/src/core/client.rs:71
variant LogSource:BothStd in /tmp/.tmp8ymZuo/testcontainers-rs/testcontainers/src/core/logs.rs:32
--- failure trait_method_added: pub trait method added ---
Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/trait_method_added.ron
Failed in:
trait method testcontainers::core::ImageExt::with_ready_conditions in file /tmp/.tmp8ymZuo/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:184
trait method testcontainers::core::ImageExt::with_health_check in file /tmp/.tmp8ymZuo/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:206
trait method testcontainers::ImageExt::with_ready_conditions in file /tmp/.tmp8ymZuo/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:184
trait method testcontainers::ImageExt::with_health_check in file /tmp/.tmp8ymZuo/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:206
```
<details><summary><i><b>Changelog</b></i></summary><p>
<blockquote>
## [0.25.0] - 2025-07-27
### Details
#### Bug Fixes
- Make tls features optional
([#806](#806))
- Add `Send` trait to `stderr` & `stdout` of `ExecResult`
([#809](#809))
- Added new parse rule for correctly parsing ports without protocol
specifier
([#812](#812))
#### Features
- Allow ready conditions customization via ImageExt
([#794](#794))
- Allow to wait for log line on either stdout or stderr
([#795](#795))
- Add `Container*::exit_code`
([#791](#791))
- Add `Container*::is_running`
([#790](#790))
- Add custom health check support for containers
([#816](#816))
- Introduce container builder api
([#801](#801))
#### Miscellaneous Tasks
- [❗] Update bollard to 1.19.1
([#817](#817))
#### Refactor
- Testimages and tests to use builder API
([#804](#804))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on feat/build-image from PR: #801