feat: platform config passing through ImageExt trait#838
feat: platform config passing through ImageExt trait#838DDtKey merged 5 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @mominul 👋 Thanks for the contribution! I think we may want to have both, but platform detection relying on default Docker's methods ( Exposing a way to configure platform from the code looks reasonable as well, but it's more like addition, not a replacement of #800 & #837 What do you think about co-existence of both approaches? (with the following priory: explicitly configured in the code > auto-detection > fallback) |
96e0440 to
2e01041
Compare
DDtKey
left a comment
There was a problem hiding this comment.
It looks good to me and provides enough of flexibility to users! 🚀
Thanks for the contribution!
@mervyn-mccreight WDYT?
It follows my suggestion above with the following priority:
- explicit config from code (this PR)
- auto-detected platform
- fallback to default
|
Friendly ping ✋ Is anything remaining from my end? |
## 🤖 New release * `testcontainers`: 0.25.1 -> 0.25.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.25.2] - 2025-10-27 ### Details #### Features - Platform config passing through ImageExt trait ([#838](#838)) #### Miscellaneous Tasks - Remove usage of reqwest hickory dns feature ([#860](#860)) - Drop weak dependencies due to cargo bug ([#862](#862)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Artem Medvedev <i@ddtkey.com>
* `testcontainers`: 0.25.1 -> 0.25.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> - Platform config passing through ImageExt trait ([#838](#838)) - Remove usage of reqwest hickory dns feature ([#860](#860)) - Drop weak dependencies due to cargo bug ([#862](#862)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Artem Medvedev <i@ddtkey.com>
Alternative approach to #800 #837I think this approach gives more flexibility API-wise. I am happy to add tests if the maintainers think this is a more suitable approach.
Fixes #500, #718
Thanks in advance!