Add typing #490
Merged
Add typing #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Looks good to me. Can you fix ruff? |
Signed-off-by: Stephen Finucane <[email protected]>
Run both check and format. Signed-off-by: Stephen Finucane <[email protected]>
This is now typed. Signed-off-by: Stephen Finucane <[email protected]>
Well, sort of. We immediately disable many of the strict checks for most modules, but doing things this way allows us to iteratively add types. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
Contributor
Author
|
@jelmer this should finally be good to be. I had to split linting into a separate job since mypy doesn't seem to work under pypy but that shouldn't be too controversial. |
Member
|
@stephenfin Thanks! |
Contributor
Author
|
🙏 Could we get a release out at some point before the New Year with this included? I'd like to start benefiting from these hints in OpenStack land |
Member
@stephenfin done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #457. I have pushed it to a separate PR since the changes are fairly substantial, though authorship of commits is retained.