Skip to content

Fix eslint config #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix eslint config #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4535d10
chore: remove duplicated eslintConfig
rivajunior Sep 27, 2023
ddc7f47
chore: add pnpm-lock.yaml to gitignore
rivajunior Sep 27, 2023
7ed89fb
chore: rename eslint config file
rivajunior Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
node_modules
coverage
dist
9 changes: 0 additions & 9 deletions .eslintrc
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
module.exports = {
extends: './node_modules/kcd-scripts/eslint.js',
rules: {
'max-lines-per-function': 'off',
'testing-library/prefer-screen-queries': 'off',
'testing-library/no-dom-import': 'off', // We're not using React Testing Library here. We're wrapping DOM Testing Library directly
'@typescript-eslint/no-explicit-any': 'off', // let's do better in the future
},
}
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ dist
# when working with contributors
package-lock.json
yarn.lock
pnpm-lock.yaml

# cypress recordings during a test run are temporary files
/cypress/videos/
Expand Down
13 changes: 0 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,6 @@
"peerDependencies": {
"cypress": "^12.0.0 || ^13.0.0"
},
"eslintConfig": {
"extends": "./node_modules/kcd-scripts/eslint.js",
"rules": {
"import/prefer-default-export": "off",
"import/no-unassigned-import": "off",
"jest/valid-expect": "off"
}
},
"eslintIgnore": [
"node_modules",
"coverage",
"dist"
],
"repository": {
"type": "git",
"url": "https://github.com/kentcdodds/cypress-testing-library"
Expand Down