feat: expand async matcher support#1040
Merged
Belco90 merged 5 commits intotesting-library:mainfrom Jul 14, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
+ Coverage 96.30% 96.49% +0.18%
==========================================
Files 47 49 +2
Lines 2542 2679 +137
Branches 1047 1106 +59
==========================================
+ Hits 2448 2585 +137
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
reviewed
Jul 10, 2025
Member
Belco90
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I added some comments, but the implementation seems fine in general.
Belco90
approved these changes
Jul 14, 2025
Member
|
@all-contributors please add @puglyfe for code and test |
Contributor
|
I've put up a pull request to add @puglyfe! 🎉 |
|
🎉 This PR is included in version 7.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
This expands support for additional async matchers (specifically, jasmine) to reduce false positives for
await-async-queriesandawait-async-utils. As mentioned in the linked issue, I understand any hesitancy to include framework-specific logic, but I think this is a relatively trivial addition to open up support to another testing framework.Context
Fixes #1039