fix: allow un-called async util references #1061
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puglyfe
commented
Aug 8, 2025
| @@ -113,6 +113,11 @@ ruleTester.run(RULE_NAME, rule, { | |||
| testingFramework: '@marko/testing-library', | |||
| }), | |||
|
|
|||
| // async queries not called are valid | |||
There was a problem hiding this comment.
this behavior already existed - just codifying it via test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
=======================================
Coverage ? 96.44%
=======================================
Files ? 50
Lines ? 2698
Branches ? 1115
=======================================
Hits ? 2602
Misses ? 96
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
reviewed
Aug 11, 2025
puglyfe
force-pushed
the
allow-async-refs
branch
from
ef0dde3 to
36b3bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
This prevents false positives for the case where async utils are referenced but not called. This matches the behavior in both
await-async-eventsandawait-async-queries.await-async-eventsexplicitly tests for this behavior here and here.await-async-queriesdoesn't explicitly test for this, but follows a similar implementation of only processingCallExpressionnodes rather thanCallExpression Identifiernodes.await-async-utilsawait-async-queriesto prevent regressions in existing behaviorContext
fixes #1060