Skip to content

Conversation

@friederbluemle
Copy link
Contributor

Checks

Changes

Remove pnpm field from engines in package.json

Context

During dependency installation in my project using Yarn, I noticed the following message:

warning [email protected]: The engine "pnpm" appears to be invalid.

The pnpm entry in engines was introduced in #966, which migrated from npm to pnpm. The same PR also correctly sets packageManager to pnpm - That's the important field used when developing eslint-plugin-testing-library itself.

There is no reason to require consumers of eslint-plugin-testing-library to use pnpm (or any specific package manager). Therefore, the best solution is to simply remove the entry from engines altogether.

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@friederbluemle Good point! Thanks 🙏

@Belco90 Belco90 changed the title Remove pnpm from engines fix: remove pnpm from engines Nov 21, 2025
@Belco90 Belco90 enabled auto-merge (squash) November 21, 2025 17:48
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.51%. Comparing base (67ade2e) to head (3e04994).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1117   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          51       51           
  Lines        2872     2873    +1     
  Branches     1179     1175    -4     
=======================================
+ Hits         2772     2773    +1     
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Belco90 Belco90 merged commit 7a248d8 into testing-library:main Nov 21, 2025
31 checks passed
@github-actions
Copy link

🎉 This PR is included in version 7.13.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants