Skip to content

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Sep 27, 2024

Checks

Changes

  • Upgrades Prettier to v3
  • Removes unused eslint-plugin-prettier
  • Rewrites tools/generate-configs to be async

Context

Prettier v3 removes its sync API, so to upgrade we now have to use promises

Relates to #826 and #855

@G-Rath G-Rath mentioned this pull request Sep 27, 2024
8 tasks
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (93a6ab9) to head (e6cc9dd).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   96.23%   96.28%   +0.04%     
==========================================
  Files          44       44              
  Lines        2419     2449      +30     
  Branches     1000     1018      +18     
==========================================
+ Hits         2328     2358      +30     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelDeBoey MichaelDeBoey changed the title chore: upgrade to Prettier v3 chore(deps-dev): upgrade Prettier to v3 Oct 16, 2024
MichaelDeBoey
MichaelDeBoey previously approved these changes Oct 16, 2024
@MichaelDeBoey MichaelDeBoey requested a review from Belco90 October 16, 2024 22:11
@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Oct 16, 2024
@Belco90
Copy link
Member

Belco90 commented Oct 17, 2024

@G-Rath can you resolve the conflicts with main? So I merge this one before other changes.

@Belco90 Belco90 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into testing-library:main with commit b7735da Oct 17, 2024
37 checks passed
@G-Rath G-Rath deleted the upgrade-prettier branch October 17, 2024 22:27
Copy link

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants