Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 668 668
Branches 254 254
=========================================
Hits 668 668 ☔ View full report in Codecov by Sentry. |
|
JSDOM v22 drops support for Node 14 while jest-dom still supports Node 14 for the current (v6) version Can we first create a PR that upgrades to Node v21 which still supports Node 14? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Upgrade jsdom dep to 23.2.0.
Since this version of the library uses a "logical OR" operator, I also bumped GH runner's node version from 14 to 16.
Why:
This release resolves a bug with the CSS selector engine. More information about this bug can be found in this react-testing-library issue.
More information about how the CSS selector bug was resolved can be found in the jsdom@23.2.0 release notes
How:
Upgraded the dependency.
Checklist: