fix: prevent click event on non-focusable control#1130
Merged
ph-fritsche merged 1 commit intotesting-library:mainfrom Jan 21, 2025
Merged
fix: prevent click event on non-focusable control#1130ph-fritsche merged 1 commit intotesting-library:mainfrom
ph-fritsche merged 1 commit intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Is this waiting on contributor updates or for TL team to approve? Would love for this to get implemented, as currently blocking us from using 14.x |
When a label with a control is clicked, the click is forwarded even if the control is not focusable (i.e. disabled or hidden). This change addresses that issue. Resolves testing-library#1057 Also, updating the how to contribute tutorial link in CONTRIBUTING.md.
ph-fritsche
force-pushed
the
pr/fix-click-on-non-focusable-input
branch
from
b9bd1dc to
ba9e6e2
Compare
ph-fritsche
approved these changes
Jan 21, 2025
Member
ph-fritsche
left a comment
ph-fritsche
left a comment
There was a problem hiding this comment.
Thanks for contributing to this library. 💙
|
🎉 This PR is included in version 14.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
|
Should there be an error or warning instead of just ignoring the click? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Resolves #1057. This change stops click events from being forwarded to non-focusable inputs from labels.
Why:
Currently, click events are being forwarded to inputs from labels. This is expected behavior unless the input is disabled or hidden or otherwise not focusable. This behavior break tests that rely on clicking labels of disabled inputs.
How:
The function call forwarding the click was moved inside the conditional checking if the control was focusable.
Checklist:
Also, updating the "How to Contribute" egghead tutorial link in CONTRIBUTING.md.
Based on @nknapp's suggestion.