Update PointerEvent to have default width / height set to 1#1224
Merged
ph-fritsche merged 3 commits intotesting-library:mainfrom Jan 21, 2025
Merged
Update PointerEvent to have default width / height set to 1#1224ph-fritsche merged 3 commits intotesting-library:mainfrom
ph-fritsche merged 3 commits intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
chuganzy
commented
Jun 11, 2024
ba92085 to
e2bcaf6
Compare
Contributor
|
Any chance this PR could be merged? This affects pointer event handling by React Aria, which checks width / height to determine if events are coming from virtual clicks (e.g. screen readers). |
ph-fritsche
approved these changes
Jan 17, 2025
|
🎉 This PR is included in version 14.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Contributor
Author
|
Thank you for the release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR updates
PointerEventto have default width / height set to1as per the spec.Why:
new PointerEvent('xxx')on most browser implementations should set them1by default.Also some libraries check if a pointer event is virtual or not by looking at the geometry values, while we expect this library to work exactly as the actual interactions.
How:
Just use
1as default values on them.Checklist: