Add brackets ([]{}) to defaultKeyMap for keyboard()/type()#1226
Merged
ph-fritsche merged 2 commits intotesting-library:mainfrom Jan 21, 2025
Merged
Add brackets ([]{}) to defaultKeyMap for keyboard()/type()#1226ph-fritsche merged 2 commits intotesting-library:mainfrom
[]{}) to defaultKeyMap for keyboard()/type()#1226ph-fritsche merged 2 commits intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
bawjensen
force-pushed
the
support-brackets
branch
from
adac138 to
e521f50
Compare
ph-fritsche
force-pushed
the
support-brackets
branch
from
e521f50 to
3cfa02c
Compare
ph-fritsche
approved these changes
Jan 17, 2025
|
🎉 This PR is included in version 14.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Adding support for brackets to address #1225
Why:
To allow easier testing of functionality that relies on both
keyandcodebeing valid for keyboard events involving left/right bracketsHow:
Updated
keyMap.ts, ran the test suite.Checklist:
I'm unclear whether any documentation needs updating, since I imagine this just falls under the heading of the TODO at the bottom of
keyMap.ts, i.e. this is simply filling out the mappings.Also I considered the updates to the existing tests enough, but it's possibly I ought to add more test cases (namely for the right bracket cases).