Skip to content

Address 2952 #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: 3.3dev
Choose a base branch
from
Open

Address 2952 #2954

wants to merge 16 commits into from

Conversation

@drwetter
Copy link
Collaborator

@drwetter drwetter commented Nov 24, 2025 •
edited
Loading

This PR fixes #2952 in t/21_baseline_starttls.t:

  • it removes --ssl-native completely from STARTTLS checks
  • For mac: uses homebrews openssl for socket tests, if available

Also it cleans up the OS variable check from two other checks, example.com instead of cloudflare is used (cf blocks), more flush hacks added

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

@drwetter
remove STARTTLS
7b2804d
@drwetter
For MacOS we rather use homebrew's OpenSSL
7ba99cd
@drwetter
proper definition of os variable
d359e11
@drwetter
fix remainder from old os definition
e8098fc
@drwetter
Merge branch '3.3dev' into address_2952
4582bd8
@drwetter
Just add comments, reorder lines
0ef742a
@drwetter
Akamai keeps connection open (opossum check problem)
fc499cb
@drwetter
remove LFs and comment
7e97fef
@drwetter
Make this work undeer MacOS
8103a0e 
- URI is now example.com bc Akamai doesn't block too many checks
  (MacOS runner was delayed and often hiccuped here)
- failed to flush message --prevention
- term pattern seems better than the "colorized list"
@drwetter
reorder lines
3591f70
@drwetter
term pattern seems better than the "colorized list"
853da2a
@drwetter
Add autoflush thingy for MAcOS
f3ebf0e
@drwetter
spellcheck
a4b6d1f
@drwetter
define file var before using it
964e892
@drwetter
json and html unit tests more seamless
7823699 
- html_file / json_file
- file name comes in command, not earlier
- Both a title
- avoid fixed string for file names over and over
@drwetter
re-add $
3a0a6ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GHA: STARTTLS

2 participants

@drwetter