-
Notifications
You must be signed in to change notification settings - Fork 18
QVAC-6158: Fix CI cmake pkg on Tether fork #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QVAC-6158: Fix CI cmake pkg on Tether fork #27
Conversation
80d71b1 to
acf1a91
Compare
| cmake --install build --prefix "$PREFIX" --config Release | ||
| export LLAMA_CONFIG="$PREFIX"/lib/cmake/llama/llama-config.cmake | ||
| export LLAMA_CONFIG="$PREFIX"/share/llama/llama-config.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for my understanding, does not runners defines in the yaml file? how come we use different runners than upstream repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are using self-hosted runners, even for Linux in order to test in multiple hardware. That already could be causing some differences in the default install dir of the environment.
However, I think you are right. This one might not be related to runners at all since GH Linux Ubuntu runner should still use the default /lib (edited the description). Looking more closely at our changes I think its related to the modified CMakeLists.txt where we added the following:
install(
EXPORT llama-targets
FILE llama-targets.cmake
NAMESPACE llama::
DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/llama)
install(
FILES ${CMAKE_CURRENT_BINARY_DIR}/llama-config.cmake
DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/llama)
Our install path is not based on
/libbut/shared. Update the workflow so that the files are found on the correct folder for our fork. In addition, CMake needs to link againstllama::llamanotllamato be able to find the correct include directories.See CI for cmake-pkg now green: https://github.com/tetherto/qvac-ext-lib-llama.cpp/actions/runs/18161795175/job/51694115100?pr=27#logs
Seems to be related to this changes that we introduced in our fork: