QVAC-7519: Fix dynamic libs path with vcpkg install #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately after incorporating review comment, the previous fix attempt still broke CI.
See comment:
https://github.com/tetherto/qvac-lib-infer-llamacpp-llm/pull/302#issuecomment-3504366986 and #57 (comment)
The official documentation does not specify LIBDIR is only static libraries or only for linked (and not dynamic) libraries. On the contrary, BINDIR it specifies its for executables, which shared libraries are not:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
If you look at /usr/lib (the mention default path on Debian) it contains .so files. So object code libraries means/includes shared libraries (which can be linked or opened at runtime, its not specified).