Skip to content

Conversation

@jesusmb1995
Copy link

@jesusmb1995 jesusmb1995 commented Nov 10, 2025

Unfortunately after incorporating review comment, the previous fix attempt still broke CI.

See comment:
https://github.com/tetherto/qvac-lib-infer-llamacpp-llm/pull/302#issuecomment-3504366986 and #57 (comment)

See broken CI: https://github.com/tetherto/qvac-lib-infer-llamacpp-llm/actions/runs/19176918450/job/54827034875?pr=302

The official documentation does not specify LIBDIR is only static libraries or only for linked (and not dynamic) libraries. On the contrary, BINDIR it specifies its for executables, which shared libraries are not:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

where <dir> is one of:
BINDIR
user executables (bin)

LIBDIR
object code libraries (lib or lib64)

On Debian, this may be lib/ when CMAKE_INSTALL_PREFIX is /usr.

If you look at /usr/lib (the mention default path on Debian) it contains .so files. So object code libraries means/includes shared libraries (which can be linked or opened at runtime, its not specified).

This time I used a tagged version for the vcpkg registry PR: https://github.com/tetherto/qvac-registry-vcpkg/pull/57

And LLM CI now returns: https://github.com/tetherto/qvac-lib-infer-llamacpp-llm/actions/runs/19226902177/job/54956228035?pr=302 (Please take a careful look at the looks, e.g. cache, etc and actual tar sources being downloaded). Seems correct sources after inspection.

Downloading https://github.com/jesusmb1995/llama.cpp/archive/v6469.1.2.tar.gz -> jesusmb1995-llama.cpp-v6469.1.2.tar.gz
Successfully downloaded jesusmb1995-llama.cpp-v6469.1.2.tar.gz

Not sure why CI now fails in some of the tests whereas previous 2 PR's had no issues whatsoever. And this is a minimal change that should not affect results.

@jesusmb1995
Copy link
Author

jesusmb1995 commented Nov 10, 2025

Not sure why CI now fails in some of the tests whereas previous 2 PR's had no issues whatsoever. And this is a minimal change that should not affect results.

https://github.com/tetherto/qvac-ext-lib-llama.cpp/actions/runs/19170959484 3:12 PM has CI in green now now fails. #57 original PR was at 3:10 PM and change to BINDIR was only at https://github.com/tetherto/qvac-ext-lib-llama.cpp/compare/0ad886453f5b3f3dec273a2eaf30d9fbcea3255f..a4061159a1e5c4ba91e4b0cef7ac1b87aeb1ce0f 3:55PM
11:47
The ones failing dont even use the DL, there is no reason why they should be affected and fail now:

  ubuntu-22-cmake-vulkan:
    runs-on: ubuntu-22.04
...
        id: cmake_build
        run: |
          cmake -B build \
            -DGGML_VULKAN=ON
          cmake --build build --config Release -j $(nproc)

The DL option is OFF by default:

option(BUILD_SHARED_LIBS           "ggml: build shared libraries" ${BUILD_SHARED_LIBS_DEFAULT})

@jesusmb1995
Copy link
Author

jesusmb1995 commented Nov 10, 2025

Now however cuda 12.4 fails, this seems also unrelated. Unknown why the tests are flaky.
windows-2022-cmake-cuda (12.4) (Fails installing CUDA)

@jpgaribotti jpgaribotti merged commit c990f3d into tetherto:temp-latest Nov 10, 2025
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants