Fix geglu back & Add gemma chat-template support #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makaveli10
commented
Nov 19, 2025
makaveli10
commented
- Fix geglu backward
- Add geglu_back test
- Add support for using defualt chat-template from the model being fine-tuned which now supports gemma as well. This allows the instruction finetuning to run without the need of a jinja chat-template but can work with it as well.
- Fix CPU implementation: now correctly computes gelu_backward(gate, grad) instead of splitting computation across two halves - Update Vulkan shader to match corrected implementation with proper gelu_backward - Add a test for geglu_back op The previous implementation incorrectly assumed geglu_back operated on concatenated tensors and split them. The correct implementation computes the GELU backward pass element-wise on the gate values.
- Add auto-detection for Gemma format (<start_of_turn>model\n...<end_of_turn>) - Falls back to ChatML format for other models - Uses models default chat-template i.e. no need for jinja chat-template This enables instruction finetuning on any model.
gianni-cor
merged commit 10fd931
into
tetherto:temp-latest-finetuning
36 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.