feature: add initial integration tests by AlonzoRicardo · Pull Request #27 · tetherto/wdk-wallet-tron

AlonzoRicardo · 2026-02-13T22:03:14Z

Description

Motivation and Context

Related Issue

PR fixes the following issue:

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Davi0kProgramsThings · 2026-03-08T03:35:34Z

package.json

-    "test:coverage": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage"
+    "test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathIgnorePatterns=tests/integration",
+    "test:coverage": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage --testPathIgnorePatterns=tests/integration",
+    "compile:tron": "npx hardhat compile --network tron --config tests/artifacts/hardhat.config.cjs",


Instead of compiling its smart contract, it would be better to include the artifact directly in the repo like we are doing in wallet-evm:
https://github.com/tetherto/wdk-wallet-evm/blob/main/tests/artifacts/TestToken.json

Davi0kProgramsThings · 2026-03-08T03:37:33Z

package.json

+    "test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathIgnorePatterns=tests/integration",
+    "test:coverage": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage --testPathIgnorePatterns=tests/integration",


npm test should run both unit and integration tests:

Suggested change

"test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathIgnorePatterns=tests/integration",

"test:coverage": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage --testPathIgnorePatterns=tests/integration",

"test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest",

"test:coverage": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage",

Davi0kProgramsThings · 2026-03-08T03:49:14Z

package.json

+    "test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathIgnorePatterns=tests/integration",
+    "test:coverage": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage --testPathIgnorePatterns=tests/integration",
+    "compile:tron": "npx hardhat compile --network tron --config tests/artifacts/hardhat.config.cjs",
+    "test:integration": "npm run compile:tron && cross-env NODE_OPTIONS=--experimental-vm-modules jest tests/integration/module.test.js --testTimeout 120000 --transform '{}' --runInBand",


We don't really get any benefit from using the --runInBand option. Actually, it might slow down the execution time of the tests when they are run on our machines since this option makes them run serially on a single thread. It might make sense to enable this flag in the ci/cd of the project though, since it may reduce the running time of the build workflow.

I'm also not sure about the purpose of the --transform option, i couldn't even find it in the documentation.

Davi0kProgramsThings · 2026-03-08T03:51:30Z

package.json

      "bare.js",
-      "tests/**/*.js"
+      "tests/**/*.js",
+      "tests/artifacts/hardhat.config.cjs"


No need to ignore this file.

Davi0kProgramsThings · 2026-03-08T03:53:18Z

tests/artifacts/hardhat.config.cjs

By including the artifact in the repo, hardhat becomes quite useless. We should be able to get rid of it completely, along with the layerzero plugins.

Davi0kProgramsThings · 2026-03-08T05:14:15Z

tests/integration/module.test.js

+    expect(isValid).toBe(true)
+  }, TIMEOUT)
+
+  test('should convert a full account to read-only and perform balance, quote and receipt operations', async () => {


There's no need for this test.

Davi0kProgramsThings · 2026-03-08T05:17:40Z

tests/integration/module.test.js

+    for (const acc of [acc0, acc1]) {
+      expect(acc.keyPair.privateKey).toBeFalsy()
+
+      await expect(acc.sign('Hello, world!')).rejects.toThrow()


We should verify that the 'sendTransaction' and the 'transfer' method start throwing as well after disposing the wallet. Also, always assert against a specific error message or pattern instead of just requiring the method to throw:

Suggested change

await expect(acc.sign('Hello, world!')).rejects.toThrow()

await expect(acc.sign('Hello, world!')).rejects.toThrow('The expected error message...')

Davi0kProgramsThings · 2026-03-08T05:18:34Z

tests/integration/module.test.js

+    disposableManager.dispose()
+
+    for (const acc of [acc0, acc1]) {
+      expect(acc.keyPair.privateKey).toBeFalsy()


The private key should be null after disposing the account (see here):

Suggested change

expect(acc.keyPair.privateKey).toBeFalsy()

expect(acc.keyPair.privateKey).toBe(null)

Davi0kProgramsThings · 2026-03-08T05:18:57Z

tests/integration/module.test.js

+
+    const TRANSFER = {
+      token: setup.testTokenAddress,
+      recipient: await (await walletManager.getAccount(1)).getAddress(),


Let's use a different address here too.

Davi0kProgramsThings · 2026-03-08T05:22:01Z

tests/helpers/setup.js

+/**
+ * Blocks until the Tron node is producing blocks.
+ *
+ * @param {TronWeb} tronWeb


If we want to provide doc comments for testing components as well, then we must do it properly. So, either we get rid of them or we provide the missing descriptions for arguments and return values in this method and the methods below.

…ning

…fic error message

…actionFee) instead of using the hardcoded constant

AlonzoRicardo requested review from Davi0kProgramsThings and jonathunne February 13, 2026 22:03

AlonzoRicardo self-assigned this Feb 13, 2026

Davi0kProgramsThings requested changes Mar 8, 2026

View reviewed changes

Ricardo Alonzo and others added 12 commits March 9, 2026 17:25

feature: add initial integration tests

0640990

fix: use compiled contract and remove hardhat and useless dependencies

f2beee6

fix: simplify test scripts

6e90504

chore: Remove the JSDoc comments and other comments

9d05441

chore: Move account fundting to setup script and remove optional chai…

0527558

…ning

chore: Inverted waitForTx signature

9ec4bb5

chore: Use a fixed RECIPIENT_ADDRESS on tests

cb95bec

chore: decodes the TRC20 transfer calldata on test

c6c0824

chore: Added sendTransaction and transfer throw assertions with speci…

3cf30d5

…fic error message

fix: Fetch bandwidthPrice dynamically from chain parameters (getTrans…

d025ef0

…actionFee) instead of using the hardcoded constant

fix: test setup after tron dep upgrade

c15369c

fix: tests check fee spending by balance difference

4ffb32b

AlonzoRicardo force-pushed the feature/add-integration-tests branch from 1d4fe40 to 4ffb32b Compare March 10, 2026 00:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: add initial integration tests#27

feature: add initial integration tests#27
AlonzoRicardo wants to merge 12 commits intotetherto:developfrom
AlonzoRicardo:feature/add-integration-tests

AlonzoRicardo commented Feb 13, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Davi0kProgramsThings Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		"test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathIgnorePatterns=tests/integration",
		"test:coverage": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage --testPathIgnorePatterns=tests/integration",

	await expect(acc.sign('Hello, world!')).rejects.toThrow()
	await expect(acc.sign('Hello, world!')).rejects.toThrow('The expected error message...')

	expect(acc.keyPair.privateKey).toBeFalsy()
	expect(acc.keyPair.privateKey).toBe(null)

Conversation

AlonzoRicardo commented Feb 13, 2026

Description

Motivation and Context

Related Issue

Type of change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants