fix: prevent token mutation #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
added
the
Type: Refactoring
Fixed TypeScript compilation error where concatJoishiTokens was expecting a mutable array but received a readonly array from the tokenize function. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Thanks |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
concatTokenが引数として渡された元トークンを変更せずに処理するよう修正しました。背景
kuromojinは同一テキストに対してトークンをキャッシュします。そのため、リントを複数回実行すると、キャッシュされたトークンが書き換えられ、同一の入力に対して実行するたびにエラー範囲やメッセージが変化してしまう不具合がありました。こちらが不具合の再現のリポジトリです。
変更点
token-utils.ts
concatTokenで引数のオブジェクトを書き換えず、新しいオブジェクトを返すようにしました。no-doubled-joshi.ts
matchExceptionRuleとtoTextWithPrevWordに渡す配列をconcatedJoshiTokensに変更indexOfが使われている場所があったため、concatTokenが新しいオブジェクトを返しても正しく動作するように変更しました。補足
↓のように、モジュールとしてtextlintを使用した際に起こる不具合の修正です。
https://textlint.org/docs/use-as-modules#overview