feat: enable the pMemoize's parameter maxAge to be passed as a rule option#169
Merged
azu merged 2 commits intotextlint-rule:masterfrom Dec 21, 2025
Conversation
ajfAfg
deleted the
feat/enable-pMemoize-parameter-maxAge-to-be-passed-as-rule-option
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When dealing with a large number of documents, the execution time for this rule often exceeds one hour. Previously,
pMemoize'smaxAgewas always set to 30 seconds, which meant the same link could be inspected multiple times.Approach
I added an option to specify
pMemoize'smaxAge. I named itlinkMaxAgebecause I thought users might not immediately recognizemaxAgeas referring to cache duration. I don't consider this the best name, so I welcome suggestions for a better one.In addition to the above change, I added an explanation about
linkMaxAgeto the README.