Skip to content

Conversation

@azu
Copy link
Member

@azu azu commented Oct 11, 2025

Summary

This PR performs Node.js repository maintenance including migration from yarn v1 to pnpm and updates to GitHub Actions.

Changes

  • Migrate from yarn v1 to pnpm

    • Added pnpm-workspace.yaml to support workspace configuration
    • Updated packageManager field in package.json
    • Updated GitHub Actions workflows to use pnpm
  • Update GitHub Actions

    • Pinned pnpm/action-setup to SHA (v4.2.0)
    • Updated actions/setup-node to v5.0.0
    • Updated github/codeql-action/* to v4.30.8
    • Added persist-credentials: false for security
  • Fix TypeScript errors

    • Fixed webpack type compatibility issues in @textlint/script-compiler
    • Changed webpack callback from array to single config
    • Added proper Stats type import

Verification

  • ✅ All tests pass
  • ✅ All builds succeed
  • ✅ No Node.js 18 references remain
  • pinact run --verify passes
  • ✅ No uncommitted files

@azu azu added the Type: Maintenance Repository Maintenance label Oct 11, 2025
azu and others added 2 commits October 12, 2025 00:28
…iler

The generated worker code imports @textlint/module-interop, but it wasn't
listed as a dependency. This caused webpack resolution failures in CI due
to pnpm's strict node_modules isolation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@azu azu added the Type: Bug Bug or Bug fixes label Oct 12, 2025
"@textlint/config-loader": "^15.0.1",
"@textlint/config-partial-parser": "^0.18.0",
"@textlint/kernel": "^15.0.1",
"@textlint/module-interop": "^15.0.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, compiler + pnpm failed

@azu azu merged commit 02996e3 into master Oct 12, 2025
4 checks passed
@azu azu deleted the chore/nodejs-maintenance branch October 12, 2025 00:16
This was referenced Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Bug or Bug fixes Type: Maintenance Repository Maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant