fix: ensure release failure comments are posted to PR#125
Merged
Conversation
The comment job was not running when release failed because it checked for 'released == true' which is never set on failure. Changes: - Changed condition from 'needs.release.outputs.released == true' to 'needs.release.result != skipped' - Added default empty value for VERSION in failure comment - Used bash parameter expansion to conditionally add 'v' prefix This ensures PR comments are posted for both success and failure cases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
❌ Release failed Please check the workflow logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment job was not running when release failed because it checked for 'released == true' which is never set on failure.
Changes:
This ensures PR comments are posted for both success and failure cases.
🤖 Generated with Claude Code