-
-
Notifications
You must be signed in to change notification settings - Fork 2
test: add linting integration tests #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds integration tests for Typst linting using the Japanese technical writing preset.
- Introduces a new smoke test suite covering each rule in the
textlint-rule-preset-ja-technical-writing - Provides a Typst fixture file with examples triggering each rule
- Updates
package.jsonto include the preset as a development dependency
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/integration/linting.test.ts | Adds comprehensive smoke tests for each rule in the Japanese technical-writing preset |
| test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ | Creates a fixture file with sample Typst content exercising each lint rule |
| package.json | Adds textlint-rule-preset-ja-technical-writing to devDependencies |
Comments suppressed due to low confidence (1)
test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ:7
- The fixture includes a "max-comma" section but there’s no corresponding test case in
linting.test.ts. Add anitblock to verify violations forja-technical-writing/max-comma.
== max-comma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds integration tests for the Typst plugin using the textlint-rule-preset-ja-technical-writing preset to ensure each rule emits the expected diagnostics.
- Introduce a Vitest-based integration test suite that runs textlint over a
.typfixture and asserts rule violations. - Provide a fixture file (
main.typ) covering all target rules with sample violations. - Update
package.jsonto include the new preset as a dependency.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/integration/linting.test.ts | Added an integration test suite for Typst + Japanese preset. |
| test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ | Added .typ fixture containing sample violations for each rule. |
| package.json | Added textlint-rule-preset-ja-technical-writing to deps. |
Comments suppressed due to low confidence (2)
test/integration/linting.test.ts:53
- The fixture includes a
max-commasection, but there’s no corresponding test entry inruleTests. Add a test formax-commato ensure it’s covered.
const ruleTests = [
test/integration/linting.test.ts:108
- The expected message for
ja-no-redundant-expressionis missing the opening double-quote. It should be"することが可能です"は冗長な表現to match the actual rule output.
expectedMessage: 'することが可能です"は冗長な表現',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds integration tests to validate the linting behavior using the textlint-rule-preset-ja-technical-writing preset.
- Added a new integration test file for linting (linting.test.ts)
- Introduced a fixture file with sample Typst content for testing
- Updated package.json to include the necessary dependency
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/integration/linting.test.ts | Introduces integration tests for linting rules |
| test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ | Provides test fixtures for validating linting functionality |
| package.json | Adds dependency for textlint-rule-preset-ja-technical-writing |
No description provided.