Skip to content

Conversation

@3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented Jun 1, 2025

No description provided.

@3w36zj6 3w36zj6 requested a review from Copilot June 1, 2025 12:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds integration tests for Typst linting using the Japanese technical writing preset.

  • Introduces a new smoke test suite covering each rule in the textlint-rule-preset-ja-technical-writing
  • Provides a Typst fixture file with examples triggering each rule
  • Updates package.json to include the preset as a development dependency

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

File Description
test/integration/linting.test.ts Adds comprehensive smoke tests for each rule in the Japanese technical-writing preset
test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ Creates a fixture file with sample Typst content exercising each lint rule
package.json Adds textlint-rule-preset-ja-technical-writing to devDependencies
Comments suppressed due to low confidence (1)

test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ:7

  • The fixture includes a "max-comma" section but there’s no corresponding test case in linting.test.ts. Add an it block to verify violations for ja-technical-writing/max-comma.
== max-comma

@3w36zj6 3w36zj6 requested a review from Copilot June 1, 2025 12:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds integration tests for the Typst plugin using the textlint-rule-preset-ja-technical-writing preset to ensure each rule emits the expected diagnostics.

  • Introduce a Vitest-based integration test suite that runs textlint over a .typ fixture and asserts rule violations.
  • Provide a fixture file (main.typ) covering all target rules with sample violations.
  • Update package.json to include the new preset as a dependency.

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

File Description
test/integration/linting.test.ts Added an integration test suite for Typst + Japanese preset.
test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ Added .typ fixture containing sample violations for each rule.
package.json Added textlint-rule-preset-ja-technical-writing to deps.
Comments suppressed due to low confidence (2)

test/integration/linting.test.ts:53

  • The fixture includes a max-comma section, but there’s no corresponding test entry in ruleTests. Add a test for max-comma to ensure it’s covered.
const ruleTests = [

test/integration/linting.test.ts:108

  • The expected message for ja-no-redundant-expression is missing the opening double-quote. It should be "することが可能です"は冗長な表現 to match the actual rule output.
expectedMessage: 'することが可能です"は冗長な表現',

@3w36zj6 3w36zj6 requested a review from Copilot June 1, 2025 13:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds integration tests to validate the linting behavior using the textlint-rule-preset-ja-technical-writing preset.

  • Added a new integration test file for linting (linting.test.ts)
  • Introduced a fixture file with sample Typst content for testing
  • Updated package.json to include the necessary dependency

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

File Description
test/integration/linting.test.ts Introduces integration tests for linting rules
test/integration/fixtures/smoke/textlint-rule-preset-ja-technical-writing/main.typ Provides test fixtures for validating linting functionality
package.json Adds dependency for textlint-rule-preset-ja-technical-writing

@3w36zj6 3w36zj6 merged commit 2e6507e into main Jun 1, 2025
4 checks passed
@3w36zj6 3w36zj6 deleted the feature/add-linting-test branch June 1, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant