Skip to content

Add a GitHub workflow to build project#9

Merged
anhvlttfs merged 1 commit intotfslabs:2410-hotfixfrom
SunsetMkt:master
Aug 28, 2025
Merged

Add a GitHub workflow to build project#9
anhvlttfs merged 1 commit intotfslabs:2410-hotfixfrom
SunsetMkt:master

Conversation

@SunsetMkt
Copy link
Contributor

No description provided.

@SunsetMkt
Copy link
Contributor Author

Looks good to me.

Assigning this to me won't work, because I am not in this organization. I'm not allowed to approve it.

@shiroinekotfs
Copy link
Member

Looks good to me.

Assigning this to me won't work, because I am not in this organization. I'm not allowed to approve it.

Thanks for your commit. Our team will review it as soon as I see it is the good time to merge.

Also, I assigned you for the news in PRs, not the repo review for PR.

@anhvlttfs anhvlttfs changed the base branch from master to 2410-hotfix August 28, 2025 12:56
@anhvlttfs
Copy link
Member

Hi @SunsetMkt,

I am just here to let you know that instead of merging into the master branch, I will merge your workflow into the sub branch, which is created for further review for the new release of VLMCSD.

Thanks for your contribution.

Copy link
Member

@anhvlttfs anhvlttfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow looks good. But it may need correction and error handling?

@SunsetMkt
Copy link
Contributor Author

CI is designed to be error raisable, otherwise it won't alert possible code mistakes.

@anhvlttfs anhvlttfs merged commit d3e874c into tfslabs:2410-hotfix Aug 28, 2025
9 checks passed
@anhvlttfs
Copy link
Member

Further changes will be made by a PR from 2410-hotfix to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants