Skip to content

Comments

[clangd] Allow *.h file as c++ header#128

Merged
tgtakaoka merged 1 commit intomainfrom
lsp-clangd
Feb 13, 2026
Merged

[clangd] Allow *.h file as c++ header#128
tgtakaoka merged 1 commit intomainfrom
lsp-clangd

Conversation

@tgtakaoka
Copy link
Owner

No description provided.

Copy link

@tgtakaoka-bot tgtakaoka-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approved as owner.

@gemini-code-assist
Copy link

Summary of Changes

Hello @tgtakaoka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new .clangd configuration file to enhance the developer experience when working with C++ projects. It primarily focuses on improving how clangd interprets header files and manages diagnostic checks, leading to more accurate code analysis and fewer irrelevant warnings.

Highlights

  • Clangd Configuration: Configured clangd to treat all .h files as C++ headers by default, improving C++ language support for these files.
  • Include Path: Added debugger to the clangd include paths, ensuring proper resolution of headers within that directory.
  • ClangTidy Diagnostics: Suppressed the readability-qualified-auto ClangTidy check to avoid specific diagnostic warnings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .clangd
    • Added a new clangd configuration file.
    • Configured .h files to be treated as C++ headers.
    • Included debugger in the compile flags for include paths.
    • Disabled the readability-qualified-auto ClangTidy check.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to configure clangd to treat .h files as C++ headers by adding a .clangd configuration file. However, the YAML structure of the new file is incorrect, which will prevent it from functioning as intended. Specifically, the conditional compilation flags are not properly nested, and there are duplicate top-level keys. I've provided a suggestion to correct the file's structure.

@tgtakaoka tgtakaoka merged commit 1f0e5f6 into main Feb 13, 2026
40 checks passed
@tgtakaoka tgtakaoka deleted the lsp-clangd branch February 13, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants