Skip to content

Added microservice entry-point#278

Draft
Nikita-Smirnov-Exactpro wants to merge 13 commits intomasterfrom
microservice-main
Draft

Added microservice entry-point#278
Nikita-Smirnov-Exactpro wants to merge 13 commits intomasterfrom
microservice-main

Conversation

@Nikita-Smirnov-Exactpro
Copy link
Member

No description provided.

@Nikita-Smirnov-Exactpro
Copy link
Member Author

This change should include two features:

  • microservice entry-point
  • configuration provider

@Nikita-Smirnov-Exactpro
Copy link
Member Author

Discussion results:
Common factory constructors:

  • migrate from constructors to separate static methods
  • user can be able to create common factory via craterFromArgs(vararg args: String) and createFromProvider(provider: IConfigurationProvider). Other ways should be deprecated

Common factory methods:

  • public <T> T getConfiguration(Path configPath, Class<T> configClass, ObjectMapper customObjectMapper) should be removed because this method can be implemented out side from common factory
  • protected abstract Path getPathToCustomConfiguration() should be removed after createFromProvider implementation

JsonConfigurationProvider:

  • public constructor should be replaced to a static method
  • class should be public because it is useful for tests

@github-actions
Copy link

github-actions bot commented Jun 14, 2024

Test Results

 33 files   33 suites   5s ⏱️
428 tests 428 ✅ 0 💤 0 ❌
535 runs  535 ✅ 0 💤 0 ❌

Results for commit 5582958.

♻️ This comment has been updated with latest results.

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the base branch from dev-version-5 to master June 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants