Open
Conversation
gradle updated workflows updated
transitive dependency substitution (mina-core)
OptimumCode
approved these changes
Sep 5, 2024
Comment on lines
+5
to
+9
| id 'com.palantir.docker' version '0.36.0' apply false | ||
| id 'org.owasp.dependencycheck' version '10.0.4' | ||
| id 'com.gorylenko.gradle-git-properties' version '2.4.2' apply false | ||
| id 'com.github.jk1.dependency-license-report' version '2.9' apply false | ||
| id 'de.undercouch.download' version '5.6.0' apply false |
Contributor
There was a problem hiding this comment.
suggestion: While we are here it is worth migrating to th2 gradle plugin - it should simplify our life in future
| @@ -1,5 +1,5 @@ | |||
| #Tue Apr 14 11:21:33 MSK 2020 | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip | |||
Contributor
There was a problem hiding this comment.
note: this would be the right way to update gradle wrapper version
./gradlew wrapper --gradle-version 8.7
There was a problem hiding this comment.
Please add information about suppression and explanation why was this done
Author
There was a problem hiding this comment.
There is a note in suppressions.xml file.
There was a problem hiding this comment.
This suppression isn't usual and we should explain our decision to user / client obviously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.