[TS-1928] Support keepOpen option for searchMessageGroups gRPC r…#86
Draft
Nikita-Smirnov-Exactpro wants to merge 8 commits intodev-version-2from
Draft
[TS-1928] Support keepOpen option for searchMessageGroups gRPC r…#86Nikita-Smirnov-Exactpro wants to merge 8 commits intodev-version-2from
keepOpen option for searchMessageGroups gRPC r…#86Nikita-Smirnov-Exactpro wants to merge 8 commits intodev-version-2from
Conversation
OptimumCode
reviewed
Oct 7, 2024
Member
Author
|
@isengrims : Current version has the problem internal task isn't canceled when deadline exceeded or message with timestamp more than request end time got from cradle |
Nikita-Smirnov-Exactpro
changed the title
keepOpen option for searchMessageGroups gRPC r…keepOpen option for searchMessageGroups gRPC r…
OptimumCode
reviewed
Nov 21, 2024
app/src/main/kotlin/com/exactpro/th2/lwdataprovider/grpc/GrpcDataProviderBackPressure.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/exactpro/th2/lwdataprovider/grpc/GrpcDataProviderBackPressure.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/exactpro/th2/lwdataprovider/grpc/GrpcDataProviderBackPressure.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/exactpro/th2/lwdataprovider/grpc/GrpcDataProviderImpl.kt
Outdated
Show resolved
Hide resolved
OptimumCode
approved these changes
Nov 21, 2024
OptimumCode
reviewed
Nov 22, 2024
| val allLoaded = hashSetOf<Stream>() | ||
| do { | ||
| val continuePulling = pullUpdates(request, order, sink, allLoaded) | ||
| Thread.sleep(configuration.keepOpenPullingTimeoutMs) |
Contributor
There was a problem hiding this comment.
note: please check if we should keep pulling before calling sleep method. As an alternative, I think you can call sleep method before calling pullUpdates. I think it would make sense to wait a bit before first pull attempt as well
|
|
||
| assertInstanceOf<CancelableResponseHandler>(capturedRequestContext) | ||
|
|
||
| Thread.sleep(200) |
Contributor
There was a problem hiding this comment.
suggestion: you could use awaitility library instead of sleep call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…equest