Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates SSH keychain configuration in Ansible shell setup to use a more robust block-based approach instead of a single line replacement. This change improves the reliability of SSH agent loading by checking for existing keychain files before evaluation.
- Changed from
lineinfiletoblockinfilefor better management of multi-line shell configuration - Added conditional check for existing keychain files before sourcing them
- Maintained the same keychain evaluation command with SSH agent inheritance
Comment on lines
+12
to
+13
| if [[ -f ~/.keychain/$(hostname)-sh ]]; then | ||
| . ~/.keychain/$(hostname)-sh |
There was a problem hiding this comment.
[nitpick] Using $(hostname) in shell scripts can be unreliable in some environments. Consider using $HOSTNAME environment variable or a more explicit hostname determination method for better portability.
Suggested change
| if [[ -f ~/.keychain/$(hostname)-sh ]]; then | |
| . ~/.keychain/$(hostname)-sh | |
| if [[ -f ~/.keychain/${HOSTNAME:-$(hostname)}-sh ]]; then | |
| . ~/.keychain/${HOSTNAME:-$(hostname)}-sh |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.