-
Notifications
You must be signed in to change notification settings - Fork 17
fix: make objeto property optional in PIXRecPayload type #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughIn src/types/pixDynamicPayload.ts, the PIXRecPayload type was updated: the vinculo.objeto field changed from a required string to an optional readonly string. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/types/pixDynamicPayload.ts (1)
138-138: Add a short doc comment to clarify optionality.Document when
objetois expected to be present for downstream clarity.- readonly objeto?: string; + /** Opcional: presente apenas quando aplicável ao vínculo da recorrência. */ + readonly objeto?: string;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/types/pixDynamicPayload.ts(1 hunks)
🔇 Additional comments (2)
src/types/pixDynamicPayload.ts (2)
135-141: vinculo.objeto Optionality Confirmed SafeNo occurrences of
vinculo.objeto(direct access, destructuring, or non-null assertions) were found in the codebase. Making it optional is purely a type‐level improvement with no runtime impact. LGTM.
135-141: exactOptionalPropertyTypes is not enabled – default (false) appliesI’ve searched all
tsconfig*.jsonfiles and did not findexactOptionalPropertyTypesset, so the compiler is using its default (false). That meansobjeto?: stringwill acceptundefinedwhen explicitly assigned. If that matches your intent, no change is needed; otherwise, you can enable it in yourtsconfig.json:{ "compilerOptions": { "exactOptionalPropertyTypes": true } }
## [2.8.2](v2.8.1...v2.8.2) (2025-08-15) ### Bug Fixes * make objeto property optional in PIXRecPayload type ([#37](#37)) ([a3227c1](a3227c1))
|
🎉 This issue has been resolved in version 2.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Bug fix - This is a bug fix that addresses a type definition issue.
What is the current behavior?
Before this change, the
objetoproperty in thePIXRecPayloadtype was required (line 138 in thevinculoobject). This means that when creating or working with PIX recurrence payloads, developers were forced to always provide theobjetofield, even when it might not be necessary or available in certain scenarios.What is the new behavior (if this is a feature change)?
The
objetoproperty is now optional (marked with?). This allows developers to createPIXRecPayloadobjects without necessarily providing theobjetofield, making the type definition more flexible and aligned with real-world usage scenarios where this field might not always be required.Summary by CodeRabbit
Bug Fixes
Refactor