Skip to content

Fixed typo in single responsiblity principle. #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed typo in single responsiblity principle. #124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b130707
Fixed typo in single responsiblity principle.
janzenbupa Jun 6, 2023
0257caa
Renamed a variable as
janzenbupa Jun 6, 2023
0c99721
Fixed previous commit with actual code that will compile. My previous…
janzenbupa Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1857,7 +1857,7 @@ class UserSettings

public void ChangeSettings(Settings settings)
{
if (verifyCredentials())
if (VerifyCredentials())
{
// ...
}
Expand Down Expand Up @@ -2633,7 +2633,7 @@ Thrown errors are a good thing! They mean the runtime has successfully identifie

If you need to re-throw an exception after catching it, use just 'throw'
By using this, you will save the stack trace. But in the bad option below,
you will lost the stack trace.
you will lose the stack trace.

**Bad:**

Expand Down Expand Up @@ -3121,9 +3121,9 @@ public int HashIt(string data)
for (var i = 0; i < length; i++)
{
// Get character code.
const char = data.charCodeAt(i);
const char character = data.charCodeAt(i);
// Make the hash
hash = ((hash << 5) - hash) + char;
hash = ((hash << 5) - hash) + character;
// Convert to 32-bit integer
hash &= hash;
}
Expand All @@ -3139,8 +3139,8 @@ public int HashIt(string data)
var length = data.length;
for (var i = 0; i < length; i++)
{
const char = data.charCodeAt(i);
hash = ((hash << 5) - hash) + char;
const char character = data.charCodeAt(i);
hash = ((hash << 5) - hash) + character;

// Convert to 32-bit integer
hash &= hash;
Expand Down