feat(tlsConfig): Add possiblity to trust provided CA and host at the same time #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pio-kol
approved these changes
Jan 8, 2026
…same time Signed-off-by: Davin Kevin <davin.kevin@gmail.com>
davinkevin
force-pushed
the
feat-support-ca-and-host-ca
branch
from
fff3ca6 to
78e7d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change introduces a new flag in the TLSConfig to leverage both
CACertprovided by end-users and System certificates from the host.Until now, it was not possible to do both at the same time, leading to complex configuration when cert chains are too long (k8s size limits for configMaps) or when we share certificates with other application using an "additive system" (as the opposite of the code before this PR).
Verification
I tested the code locally, but I'm open to more testing as my client was built into
mimir, so maybe not good enough.NOTE I've opened a PR as this change is so small, it would be simpler to discuss around a PR than an issue. If it's ok for you, then I'll modify the changelog and other mandatory items.
Thank you in advance.