Tracing: enable tracing for main query execution steps #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
feat/tracing-improvements
branch
5 times, most recently
from
b9faa50 to
393e6f9
Compare
pedro-stanaka
force-pushed
the
feat/tracing-improvements
branch
2 times, most recently
from
6bfdf1c to
a595f5c
Compare
Signed-off-by: Pedro Tanaka <[email protected]> fixing go mods and docs Signed-off-by: Pedro Tanaka <[email protected]> move docs to go package Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka
force-pushed
the
feat/tracing-improvements
branch
from
9155080 to
0fd592d
Compare
Signed-off-by: Pedro Tanaka <[email protected]> appease linter Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka
force-pushed
the
feat/tracing-improvements
branch
from
0fd592d to
708a108
Compare
harry671003
approved these changes
Apr 4, 2025
Contributor
harry671003
left a comment
harry671003
left a comment
There was a problem hiding this comment.
Thanks for the great work! Left some minor comments.
As a next step, should the time taken in each operator be measured?
|
|
||
| func (e *Engine) MakeInstantQuery(ctx context.Context, q storage.Queryable, opts *QueryOpts, qs string, ts time.Time) (promql.Query, error) { | ||
| span, ctx := tracing.StartSpanFromContext(ctx, "engine.MakeInstantQuery") | ||
| defer span.Finish() |
Contributor
There was a problem hiding this comment.
Do we expect the engine to take a lot of time before query execution phase? Does these spans add value?
| defer span.Finish() | ||
| span.SetTag("query_type", q.t.String()) | ||
| span.SetTag("query_string", q.String()) | ||
| if q.t == RangeQuery { |
Contributor
There was a problem hiding this comment.
nit: Should we just set start=end and step=0 for instant query?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding tracing to some steps inside the engine so we can get better visibility into where we spend time. Had to duplicate some code from Thanos to avoid cyclic dependency.
This is what a trace will look like: