engine: remove counter suffix annotation #554
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/remove-counter-warning-info-annotation
branch
from
0d2a301 to
339c9cc
Compare
Collaborator
|
Is there an easy way to make annotations opt-in when creating an engine? |
|
Just as a comment to keep this PR alive, I'd love to see this incorporated. The messaging around metric naming is not helpful and can frequently clutter up the user UI, especially unhelpful where the underlaying metric is in fact a real counter but just don't conform to the naming convention. |
This commit removes the annotation that is added when a metric has a name that is not indicative of a counter. This annotation is mostly spam that the query author cannot act upon. Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/remove-counter-warning-info-annotation
branch
from
339c9cc to
4821f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the annotation that is added when a metric has a name that is not indicative of a counter. This annotation is mostly spam that the query author cannot act upon.