refactor: consolidate query options into execution/execopts package#668
Open
MichaHoffmann wants to merge 1 commit intomainfrom
Open
refactor: consolidate query options into execution/execopts package#668MichaHoffmann wants to merge 1 commit intomainfrom
MichaHoffmann wants to merge 1 commit intomainfrom
Conversation
Contributor
MichaHoffmann
commented
Dec 7, 2025
MichaHoffmann
commented
- Move query.Options to execopts.Options
- Rename engine.QueryOpts to engine.QueryOptions
- Simplify QueryOptions (remove promql.QueryOpts interface)
- Delete the query package
MichaHoffmann
force-pushed
the
mhoffmann/restructure-query-options
branch
from
7e6b6b1 to
6c22538
Compare
- Move query.Options to execopts.Options - Rename engine.QueryOpts to engine.QueryOptions - Simplify QueryOptions (remove promql.QueryOpts interface) - Delete the query package Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
MichaHoffmann
force-pushed
the
mhoffmann/restructure-query-options
branch
from
6c22538 to
e7e73e7
Compare
fpetkovski
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.